-
Notifications
You must be signed in to change notification settings - Fork 10
chore: add catalog-info.yml #9
chore: add catalog-info.yml #9
Conversation
Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
catalog-info.yaml
Outdated
openedx.org/arch-interest-groups: "" | ||
openedx.org/release: "main" | ||
spec: | ||
owner: group:openedx-unmaintained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arbrandes This seems like it's new enough that we should have a maintainer. Are you the right person to be the maintainer for this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sign me up!
catalog-info.yaml
Outdated
icon: "GitHub" | ||
annotations: | ||
openedx.org/arch-interest-groups: "" | ||
openedx.org/release: "main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not put in this value by default, it should only go in if the repo is going to be tagged for releases, it should match the value in the openedx.yaml
file in the repo if it exists. If it doesn't exist, then this annotation should not be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil have removed
catalog-info.yaml
Outdated
- url: "https://github.com/ichintanjoshi/frontend-app-shell" | ||
title: "frontend-app-shell" | ||
icon: "GitHub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong link and we don't need to link to the github repo that happens automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil have updated
@ichintanjoshi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description